Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix initialization of shares json file #940

Merged
merged 1 commit into from
Jul 7, 2020

Conversation

C0rby
Copy link
Contributor

@C0rby C0rby commented Jul 6, 2020

When the json file exists but is empty the manager would fail in line 95 when trying to unmarshal the empty file.

Fixes: #941

@C0rby C0rby requested a review from labkode as a code owner July 6, 2020 16:00
@C0rby C0rby requested a review from butonic July 6, 2020 16:00
Signed-off-by: David Christofas <[email protected]>
@C0rby C0rby force-pushed the fix-sharefile-creation branch from ae3a184 to 3ea2fc5 Compare July 6, 2020 16:06
@phil-davis
Copy link
Contributor

https://cloud.drone.io/cs3org/reva/1726/4/4

# google.golang.org/protobuf/internal/impl
compile: writing output: write $WORK/b164/_pkg_.a: no space left on device
# github.com/aws/aws-sdk-go/aws/endpoints
compile: writing output: write $WORK/b522/_pkg_.a: no space left on device
# github.com/mattn/go-sqlite3
sqlite3-binding.c:228449:1: fatal error: error writing to /tmp/ccF82QmE.s: No space left on device
 SQLITE_API const char *sqlite3_sourceid(void){ return SQLITE_SOURCE_ID; }
 ^~~~~~~~~~
compilation terminated.
make: *** [Makefile:54: build-ci] Error 2

Seems to be some storage space issue on drone.

@labkode labkode merged commit 9e49158 into cs3org:master Jul 7, 2020
@butonic butonic deleted the fix-sharefile-creation branch July 7, 2020 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialization of json share manager fails if empty shares.json file exists
4 participants